ABI fix#455
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev/v4-fin #455 +/- ##
==============================================
- Coverage 42.09% 36.77% -5.32%
==============================================
Files 12 12
Lines 2238 2238
==============================================
- Hits 942 823 -119
- Misses 1296 1415 +119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Greptile SummaryThis PR fixes the ABI definition for the
Confidence Score: 5/5Single-line ABI constant fix that corrects an incomplete struct encoding; no logic or control-flow changes. The change correctly replaces an incomplete inner-struct-only tuple with the full PermitSingle tuple, matching the Permit2 contract definition and aligning with the already-correct PERMIT2_PERMIT_BATCH entry. The fix is minimal and targeted with no side effects. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant uniswap4.py
participant constants.py
participant eth_abi
Caller->>uniswap4.py: execute PERMIT2_PERMIT command
uniswap4.py->>constants.py: lookup universal_router_commands_abis["PERMIT2_PERMIT"]
Note over constants.py: Returns ["((address,uint160,uint48,uint48),address,uint256)", "bytes"]<br/>(PermitSingle: details tuple + spender + sigDeadline)
constants.py-->>uniswap4.py: ABI types list
uniswap4.py->>eth_abi: encode(types, [permitSingle, signature])
eth_abi-->>uniswap4.py: encoded bytes
uniswap4.py-->>Caller: calldata for UniversalRouter
Reviews (2): Last reviewed commit: "fix" | Re-trigger Greptile |
No description provided.