#5174: fix wrong file closing in example.

georg.brandl · georg.brandl · commit 51ce15ba2d82 · 2009-02-07T12:21:17.000Z
git-svn-id: http://svn.python.org/projects/python/trunk@69409 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Doc/library/xmlrpclib.rst b/Doc/library/xmlrpclib.rst
@@ -318,9 +318,8 @@ XMLRPC::
    import xmlrpclib
 
    def python_logo():
-        handle = open("python_logo.jpg")
-        return xmlrpclib.Binary(handle.read())
-        handle.close()
+        with open("python_logo.jpg") as handle:
+            return xmlrpclib.Binary(handle.read())
 
    server = SimpleXMLRPCServer(("localhost", 8000))
    print "Listening on port 8000..."
@@ -333,9 +332,8 @@ The client gets the image and saves it to a file::
    import xmlrpclib
 
    proxy = xmlrpclib.ServerProxy("http://localhost:8000/")
-   handle = open("fetched_python_logo.jpg", "w")
-   handle.write(proxy.python_logo().data)
-   handle.close()
+   with open("fetched_python_logo.jpg", "w") as handle:
+       handle.write(proxy.python_logo().data)
 
 .. _fault-objects:
 
