[3.11] Fix WebSocket reader flow control size calculation for multi-byte data#9686
Conversation
CodSpeed Performance ReportMerging #9686 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #9686 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 117 117
Lines 35845 35844 -1
Branches 4295 4294 -1
=======================================
Hits 35101 35101
+ Misses 558 557 -1
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
https://www.merriam-webster.com/dictionary/undercount Hmm.. guess its not in the spelling words |
a11bc73 to
03480f2
Compare
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply ea1c084 on top of patchback/backports/3.10/ea1c084d9f49e91feb2e92fea307260ad3f47376/pr-9686 Backporting merged PR #9686 into 3.11
🤖 @patchback |
…ize calculation for multi-byte data (#9709)
The decoded size was passed to the
FlowControlDataQueueinstead of the bytes size which meant multi-byte characters would be under counted.Note that this code is completely different on 3.11/3.10 than
masterso this PR is directly to 3.11