Fix panic in D208 with multibyte indent#9147
Merged
Merged
Conversation
Fix #9080 Example, where `[]` is a 2 byte non-breaking space: ``` def f(): """ ^^^^ Real indentation is 4 chars overindented ^^^^^^ overindentation is 6 - 4 = 2 chars due to this line [] [] further indented ^^^^^ we take these 4 chars/5 bytes to match the docstring ... ^^^ ... and these 2 chars/3 bytes to remove the `over_indented_size` ... ^^ ... but preserve this real indent ```
MichaReiser
approved these changes
Dec 15, 2023
Contributor
|
charliermarsh
approved these changes
Dec 15, 2023
charliermarsh
left a comment
charliermarsh
left a comment
Member
There was a problem hiding this comment.
We've had so many fuzzer bugs related to this, strings are really hard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9080
Example, where
[]is a 2 byte non-breaking space: