update mongodb without deprecated [srv] extra requirement#9258
Merged
Conversation
19 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9258 +/- ##
=======================================
Coverage 78.01% 78.01%
=======================================
Files 150 150
Lines 18828 18828
Branches 3221 3221
=======================================
Hits 14689 14689
Misses 3835 3835
Partials 304 304
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thedrow
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoids using
pymongo[srv]. The extra requirement was removed sincepymongo==4.3, because thednspythonit referred to is now required. The[srv]extra was left as an empty list of dependencies for backward compatibility and to avoid pip warnings, but was removed inpymongo==4.8. See the linked issue for more details.pymongo[srv]withpymongo==4.8.0#9254