Autoloading, dependency loading and middleware registry cleanup#1301
Merged
Conversation
olleolleolle
changed the title
olleolleolle
reviewed
Aug 8, 2021
olleolleolle
left a comment
olleolleolle
left a comment
Member
There was a problem hiding this comment.
Looks grand!
I was curious if the middleware_mutex is still in use, now.
Co-authored-by: Olle Jonsson <[email protected]>
Member
Author
|
Thanks for the quick review and the suggestions @olleolleolle 🙌! |
2 tasks
sgerrand
pushed a commit
to duffelhq/duffel-api-ruby
that referenced
this pull request
Jan 5, 2022
This class module was refactored and redesigned in lostisland/faraday#1301
timrogers
pushed a commit
to duffelhq/duffel-api-ruby
that referenced
this pull request
Jan 9, 2022
This class module was refactored and redesigned in lostisland/faraday#1301
timrogers
pushed a commit
to duffelhq/duffel-api-ruby
that referenced
this pull request
Jan 11, 2022
This class module was refactored and redesigned in lostisland/faraday#1301
timrogers
pushed a commit
to duffelhq/duffel-api-ruby
that referenced
this pull request
Jan 11, 2022
This class module was refactored and redesigned in lostisland/faraday#1301
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MiddlewareRegistryTodos
List any remaining work that needs to be done, i.e: