Skip to content

chore: capture initial branch policy settings#1470

Merged
MIchaelMainer merged 1 commit into
devfrom
branchprotectionpolicy
Jun 12, 2023
Merged

chore: capture initial branch policy settings#1470
MIchaelMainer merged 1 commit into
devfrom
branchprotectionpolicy

Conversation

@MIchaelMainer

Copy link
Copy Markdown
Collaborator

Capture current policy state so that we can make versioned changes to branch protection policies. This will enable policy history, auditing, review, standardization, and templatization. We will update policy in later PR.

We can ignore the rule that states: At least one value under RequiredStatusChecks must be specified when RequiresStrictStatusChecks is true. or RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks. This is getting removed. This is getting removed.

This branch protection policy will not take effect until https://github.com/microsoftgraph/.github/blob/main/policies/branch-protection-sdks.yml has been removed.

Capture current policy state so that we can make versioned changes to branch protection policies. This will enable policy history, auditing, review, standardization, and templatization. We will update policy in later PR.

We can ignore the rule that states: `At least one value under RequiredStatusChecks must be specified when RequiresStrictStatusChecks is true.` or `RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.` This is getting removed. This is getting removed.
* https://github.com/microsoft/GitOps.Branches/pull/73
* https://github.com/microsoft/GitOps.Branches/issues/72

This branch protection policy will not take effect until https://github.com/microsoftgraph/.github/blob/main/policies/branch-protection-sdks.yml has been removed.
@MIchaelMainer MIchaelMainer requested a review from a team as a code owner June 12, 2023 18:20
@MIchaelMainer MIchaelMainer merged commit add5797 into dev Jun 12, 2023
@MIchaelMainer MIchaelMainer deleted the branchprotectionpolicy branch June 12, 2023 22:46
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

2 invalid rules

  • RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.
  • RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.

Total execution time: 0.02 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants