chore: use ConfigurationError when package_dir is outside cwd#2898
Merged
Conversation
Replace a generic Exception with errors. ConfigurationError when package_dir is not inside the working directory. This makes the error type consistent with the project's error handling and allows the CLI to treat this as a fatal error with the expected exit behavior.
agriyakhetarpal
approved these changes
Jun 6, 2026
Fold the standalone linux_build_test.py into the existing linux_build_steps_test.py, which already covers the linux platform build orchestration. Reuses the file's existing import boilerplate and module-qualified build() call style. Assisted-by: ClaudeCode:claude-opus-4.8 Co-Authored-By: Claude Opus 4.8 <[email protected]>
Contributor
|
🤖 AI text below 🤖 Moved the new test out of a standalone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves one of the "Error Handling & Logic" items in #2854
Mostly, this changes the UX from raw traceback to a simple error log without traceback (by default) and a specific error code.
Test written with the assistance of copilot.
🤖 AI text below 🤖
Replace a generic Exception with errors.ConfigurationError when package_dir is not inside the working directory. This makes the error type consistent with the project's error handling and allows the CLI to treat this as a fatal error with the expected exit behavior.