fix: nargs should allow duplicates when duplicate-arguments-array=false (#164)

juergba · Benjamin E. Coe · commit 47ccb0b7fcca · 2019-06-07T12:30:55.000-05:00
diff --git a/index.js b/index.js
@@ -684,6 +684,14 @@ function parse (args, opts) {
     var isValueArray = Array.isArray(value)
     var duplicate = configuration['duplicate-arguments-array']
 
+    // nargs has higher priority than duplicate
+    if (!duplicate && checkAllAliases(key, flags.nargs)) {
+      duplicate = true
+      if ((!isUndefined(o[key]) && flags.nargs[key] === 1) || (Array.isArray(o[key]) && o[key].length === flags.nargs[key])) {
+        o[key] = undefined
+      }
+    }
+
     if (value === increment) {
       o[key] = increment(o[key])
     } else if (Array.isArray(o[key])) {
diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -2200,6 +2200,16 @@ describe('yargs-parser', function () {
 
         parsed['x'].should.equal('b')
       })
+      it('does not interfere with nargs', function () {
+        var parsed = parser('-x a b c -x o p q', {
+          narg: { x: 3 },
+          configuration: {
+            'duplicate-arguments-array': false
+          }
+        })
+
+        parsed['x'].should.deep.equal(['o', 'p', 'q'])
+      })
     })
 
     describe('flatten duplicate arrays', function () {
@@ -2243,7 +2253,6 @@ describe('yargs-parser', function () {
 
         parsed['x'].should.deep.equal(['a', 'b'])
       })
-
       it('flattens duplicate array type, when argument uses dot notation', function () {
         var parsed = parser('-x.foo a -x.foo b', {
           array: ['x.foo'],
